launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/garbo into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #758574 in Launchpad itself: "garbo task timeout should be dynamic"
  https://bugs.launchpad.net/launchpad/+bug/758574
  Bug #768139 in Launchpad itself: "gabo script locking behavior needs tweaking"
  https://bugs.launchpad.net/launchpad/+bug/768139

For more details, see:
https://code.launchpad.net/~stub/launchpad/garbo/+merge/58658

Hourly and daily runs should leave time for cleanup by default, to ensure they are fully terminated before the next scheduled run kicks in.
-- 
https://code.launchpad.net/~stub/launchpad/garbo/+merge/58658
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/garbo into lp:launchpad.

=== modified file 'lib/lp/scripts/garbo.py'
--- lib/lp/scripts/garbo.py	2011-04-18 15:40:02 +0000
+++ lib/lp/scripts/garbo.py	2011-04-21 12:13:55 +0000
@@ -1053,7 +1053,9 @@
         ]
     experimental_tunable_loops = []
 
-    default_abort_script_time = 60 * 60
+    # 1 hour, minus 5 minutes for cleanup. This ensures the script is
+    # fully terminated before the next scheduled hourly run kicks in.
+    default_abort_script_time = 60 * 55
 
 
 class DailyDatabaseGarbageCollector(BaseDatabaseGarbageCollector):
@@ -1075,4 +1077,6 @@
         PersonPruner,
         ]
 
-    default_abort_script_time = 60 * 60 * 24
+    # 1 day, minus 30 minutes for cleanup. This ensures the script is
+    # fully terminated before the next scheduled daily run kicks in.
+    default_abort_script_time = 60 * 60 * 23.5