launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/ignore-hidden-js-files into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~danilo/launchpad/ignore-hidden-js-files/+merge/58819

= Ignore hidden JS files in 'make jsbuild' =

Emacs keeps temporary auto-saved backup files as .#<filename>.js.  If I have a few unsaved changes in the file, 'make jsbuild' will pick up these files well, and I'll hit a problem like

$ make jsbuild
utilities/shhh.py bin/jsbuild \
	    --builddir lazr-js/build \
	    --exclude testing/ --filetype raw \
	    --copy-yui-to lazr-js/build/yui
make: *** No rule to make target `lib/lp/bugs/javascript/.#bugtask_index_portlets.js', needed by `lib/canonical/launchpad/icing/build/launchpad.js'.  Stop.

== Proposed fix ==

Skip all hidden files (names starting with ".").  I don't see a reason that any dotted files get included.  If someone does, please let me know.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  Makefile

./Makefile
      32: Line exceeds 78 characters.
     288: Line exceeds 78 characters.
     447: Line exceeds 78 characters.
     488: Line has trailing whitespace.
-- 
https://code.launchpad.net/~danilo/launchpad/ignore-hidden-js-files/+merge/58819
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/ignore-hidden-js-files into lp:launchpad.

=== modified file 'Makefile'
--- Makefile	2011-03-31 15:04:53 +0000
+++ Makefile	2011-04-22 14:13:39 +0000
@@ -29,7 +29,7 @@
 JS_YUI := $(shell utilities/yui-deps.py $(JS_BUILD:raw=))
 JS_LAZR := $(LAZR_BUILT_JS_ROOT)/lazr.js
 JS_OTHER := $(wildcard lib/canonical/launchpad/javascript/*/*.js)
-JS_LP := $(shell find lib/lp/*/javascript ! -path '*/tests/*' -name '*.js')
+JS_LP := $(shell find lib/lp/*/javascript ! -path '*/tests/*' -name '*.js' ! -name '.*.js' )
 JS_ALL := $(JS_YUI) $(JS_LAZR) $(JS_OTHER) $(JS_LP)
 JS_OUT := $(LP_BUILT_JS_ROOT)/launchpad.js