launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Benji York has proposed merging lp:~benji/launchpad/bug-770267 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #770267 in Launchpad itself: "Option text "Send me bug notifications for changes I make." has a full stop"
  https://bugs.launchpad.net/launchpad/+bug/770267

For more details, see:
https://code.launchpad.net/~benji/launchpad/bug-770267/+merge/59063

This branch fixes bug 770267: Option text "Send me bug notifications for changes I make." has a full stop.
-- 
https://code.launchpad.net/~benji/launchpad/bug-770267/+merge/59063
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~benji/launchpad/bug-770267 into lp:launchpad.

=== modified file 'lib/lp/registry/interfaces/person.py'
--- lib/lp/registry/interfaces/person.py	2011-04-20 16:40:19 +0000
+++ lib/lp/registry/interfaces/person.py	2011-04-26 14:01:20 +0000
@@ -633,7 +633,7 @@
     """
 
     selfgenerated_bugnotifications = Bool(
-        title=_("Send me bug notifications for changes I make."),
+        title=_("Send me bug notifications for changes I make"),
         required=False, default=False)
 
 

=== modified file 'lib/lp/registry/stories/person/xx-person-edit.txt'
--- lib/lp/registry/stories/person/xx-person-edit.txt	2011-02-17 09:17:00 +0000
+++ lib/lp/registry/stories/person/xx-person-edit.txt	2011-04-26 14:01:20 +0000
@@ -67,7 +67,7 @@
 actions.
 
     >>> self_generated_control = browser.getControl(
-    ...     "Send me bug notifications for changes I make.")
+    ...     "Send me bug notifications for changes I make")
     >>> self_generated_control.selected
     False
     >>> self_generated_control.click()
@@ -84,5 +84,5 @@
     ...     "bug notifications").selected
     False
     >>> browser.getControl(
-    ...     "Send me bug notifications for changes I make.").selected
+    ...     "Send me bug notifications for changes I make").selected
     True