launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/private-bugs-on-overview-739455 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #739455 in Launchpad itself: "Changing bug privacy to private doesn't remove bug from project overview page"
  https://bugs.launchpad.net/launchpad/+bug/739455

For more details, see:
https://code.launchpad.net/~deryck/launchpad/private-bugs-on-overview-739455/+merge/59259

This branch fixes bug 739455, which reports that the latest bugs list on project overview pages could continue to list a bug after it's been marked private.  This was due to memcached caching.  This branch removes that caching.

I chose to remove the caching for a number of reasons.  I don't think we're using memcache well enough to get much benefit from it, and Robert notes in the bug that those pages are still given to timeouts anyway.  This is one portlet, so we can certainly watch if this affects the timeouts there.

Also, we didn't have any test coverage of the caching of this portlet or the bugs it listed.  If I'm wrong, I would love someone to correct me.  I did a pretty liberal test regex and didn't find any failures.  ec2 test will certainly catch this if I'm wrong.

Assuming I'm correct and there is no coverage for this portlet, I think this is bad, but maybe others don't think this is worth testing, given the missing coverage.  I don't want to slow down an easy fix for adding these tests, though.  I can open a bug about the missing test.  I can also add them now if the reviewer wishes to push back hard enough. :-)  But obviously, I don't think this is required now, given this branch removes an untested feature anyway.

Thanks in advance for the review!
-- 
https://code.launchpad.net/~deryck/launchpad/private-bugs-on-overview-739455/+merge/59259
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/private-bugs-on-overview-739455 into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt'
--- lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt	2010-11-09 09:49:12 +0000
+++ lib/lp/bugs/templates/bugtarget-portlet-latestbugs.pt	2011-04-27 17:14:26 +0000
@@ -3,8 +3,7 @@
   xmlns:metal="http://xml.zope.org/namespaces/metal";
   xmlns:i18n="http://xml.zope.org/namespaces/i18n";
   class="portlet" id="portlet-latest-bugs"
-  tal:condition="view/latestBugTasks"
-  tal:content="cache:private noparam, 1 hour">
+  tal:condition="view/latestBugTasks">
   <h2><span class="see-all"><a
       tal:attributes="href context/fmt:url:bugs">All bugs</a></span>
     Latest bugs reported</h2>