launchpad-reviewers team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Brad Crittenden has proposed merging lp:~bac/launchpad/bug-770342 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #770342 in Launchpad itself: ""Unmute" dialogue is headed "Subscribe to bug""
  https://bugs.launchpad.net/launchpad/+bug/770342

For more details, see:
https://code.launchpad.net/~bac/launchpad/bug-770342/+merge/59415

= Summary =

The unmute overlay was titled "Subscribe" which is confusing.

== Proposed fix ==

Change the title when unmuting.

== Pre-implementation notes ==

None.

== Implementation details ==

Make the title a parameter to the method to create the overlay.

== Tests ==

None.

== Demo and Q/A ==

Mute a direct bug subscription then unmute it.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/javascript/bugtask_index_portlets.js
-- 
https://code.launchpad.net/~bac/launchpad/bug-770342/+merge/59415
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bac/launchpad/bug-770342 into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/bugtask_index_portlets.js'
--- lib/lp/bugs/javascript/bugtask_index_portlets.js	2011-04-28 16:08:29 +0000
+++ lib/lp/bugs/javascript/bugtask_index_portlets.js	2011-04-28 19:51:00 +0000
@@ -655,9 +655,13 @@
  * @method setup_advanced_subscription_overlay
  * @param subscription {Object} A Y.lp.bugs.subscriber.Subscription object.
  */
-function setup_advanced_subscription_overlay(subscription) {
+function setup_advanced_subscription_overlay(subscription, text) {
+    if (Y.Lang.isUndefined(text)) {
+        text = "Subscribe to bug";
+    }
+    var header = Y.Node.create('<h2 />').set('text', text);
     var subscription_overlay = new Y.lazr.FormOverlay({
-        headerContent: '<h2>Subscribe to bug</h2>',
+        headerContent: header,
         form_submit_button:
             Y.Node.create(submit_button_html),
         form_cancel_button: