launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~wallyworld/launchpad/reenable-test_recipebuild_listing_with_user into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/reenable-test_recipebuild_listing_with_user/+merge/59448

The test_recipebuild_listing_with_user() test was disabled because of a buildbot failure.

I re-ran the test locally and it passed. There's no obvious flaw with the code. It looks like some extra build records were retrieved from the query used in the test but the same base code is used to create the build records for all the tests so there's no obvious issue with that either. There's another test using almost the same code (but with anonymous login) which passed in the same test run as the one which produced the failure.

So I'm reenabling the test.
-- 
https://code.launchpad.net/~wallyworld/launchpad/reenable-test_recipebuild_listing_with_user/+merge/59448
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/reenable-test_recipebuild_listing_with_user into lp:launchpad.

=== modified file 'lib/lp/code/browser/tests/test_recipebuildslisting.py'
--- lib/lp/code/browser/tests/test_recipebuildslisting.py	2011-04-05 10:36:41 +0000
+++ lib/lp/code/browser/tests/test_recipebuildslisting.py	2011-04-29 03:25:47 +0000
@@ -87,10 +87,7 @@
         # Ensure we can see the listing when we are not logged in.
         self._test_recipebuild_listing(no_login=True)
 
-    def disabled_test_recipebuild_listing_with_user(self):
-        # XXX: JonathanLange bug=751202: This test failed for reasons unknown
-        # to me.
-        #
+    def test_recipebuild_listing_with_user(self):
         # Ensure we can see the listing when we are logged in.
         self._test_recipebuild_listing()