launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

The proposal to merge lp:~abentley/launchpad/allow-noop-claims into lp:launchpad has been updated.

Description changed to:

= Summary =
Fix bug #608778: If I click twice on Claim Review I get a ClaimReviewFailed OOPS.

== Proposed fix ==
Do nothing if attempting to claim an already-claimed review.
Convert ClaimReviewFailed into a proper user error.

== Pre-implementation notes ==
None

== Implementation details ==
As a drive-by, removed assignment to unused variables.

== Tests ==
bin/test -t test_repeat_claim -t claim_no_oops

== Demo and Q/A ==
Create a merge proposal.  Open up two copies of the merge proposal page.  Click "Claim review" in the first one.  Click "Claim review" in the second one.  No error or oops should be displayed.

Create a review request for a team you are a member of.  In a second window, reassign the request to another person.  Click "Claim review" in the first window.  It should say "Cannot claim non-team reviews".

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/browser/branchmergeproposal.py
  lib/lp/code/browser/tests/test_branchmergeproposal.py
  lib/lp/code/model/codereviewvote.py
  lib/lp/code/model/tests/test_codereviewvote.py

For more details, see:
https://code.launchpad.net/~abentley/launchpad/allow-noop-claims/+merge/59795
-- 
https://code.launchpad.net/~abentley/launchpad/allow-noop-claims/+merge/59795
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/allow-noop-claims into lp:launchpad.