launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

The proposal to merge lp:~benji/launchpad/click-to-close-boxes into lp:launchpad has been updated.

Description changed to:

I recently used the "informational message" classes when building user
action feedback boxes.  When reviewing the branch Gary suggested that it
would be nice if the boxes would go away when clicked.  This branch is
the result of that request.

CSS is used to add a "(Click to close)" message to the bottom right of
the box.  If the text in the message would otherwise occupy the bottom
right the message will be pushed down.

A small JS snippet was added to react to a click event on any message
box by hiding the box.

The make lint report is clean.

To view this in action, start a dev instance and visit
https://bugs.launchpad.dev/redfish/+bug/15/+subscribe.

I made two screen shots of the change.  One with a message short enough
that the click-to-close message is on the same line as the last line of
text, and another that has longer text that forces the click-to-close
text down.  The screen shots are at http://imgur.com/a/aByCi.

For more details, see:
https://code.launchpad.net/~benji/launchpad/click-to-close-boxes/+merge/59818
-- 
https://code.launchpad.net/~benji/launchpad/click-to-close-boxes/+merge/59818
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~benji/launchpad/click-to-close-boxes into lp:launchpad.