launchpad-reviewers team mailing list archive

Thread
Date

[Merge] lp:~benji/launchpad/bug-777794 into lp:launchpad

To: mp+60209@xxxxxxxxxxxxxxxxxx
From: Benji York <benji@xxxxxxxxxxxxx>
Date: Fri, 06 May 2011 15:51:38 -0000
Reply-to: mp+60209@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Benji York has proposed merging lp:~benji/launchpad/bug-777794 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #777794 in Launchpad itself: "Bug subscription AJAX popups are too bold"
  https://bugs.launchpad.net/launchpad/+bug/777794

For more details, see:
https://code.launchpad.net/~benji/launchpad/bug-777794/+merge/60209

Bug 777794 points out that the text of the bug subscription overlay
forms is unnecessarily bolded.  This branch fixes that.

Before: http://i.imgur.com/leIsl.png
After: http://i.imgur.com/i7gyy.png

The make lint report is clean.

-- 
https://code.launchpad.net/~benji/launchpad/bug-777794/+merge/60209
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~benji/launchpad/bug-777794 into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bug-subscription.pt'
--- lib/lp/bugs/templates/bug-subscription.pt	2011-04-27 09:57:42 +0000
+++ lib/lp/bugs/templates/bug-subscription.pt	2011-05-06 15:51:30 +0000
@@ -24,6 +24,16 @@
                 });
             });
     </script>
+
+    <!-- It normally makes sense for form labels to be bold, but since this
+         form consists only of radio buttons, there's nothing but labels so we
+         just get wall-to-wall bold.  This rule turns the bold off. -->
+    <style type="text/css">
+      form table label {
+          font-weight: normal !important;
+      }
+    </style>
+
   </metal:block>
 
 <body>

=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt	2011-04-22 12:56:09 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt	2011-05-06 15:51:30 +0000
@@ -61,6 +61,14 @@
         .bug-branch-summary dd { font-size: 85% }
         a#privacy-link:link:hover, a#privacy-link:visited:hover {text-decoration:none;}
       </style>
+      <style type="text/css">
+        .yui3-overlay .value label  {
+          /* It normally makes sense for form labels to be bold, but since
+          this form consists only of radio buttons, there's nothing but labels
+          so we just get wall-to-wall bold. */
+          font-weight: normal !important;
+        }
+      </style>
     </metal:block>
 
     <metal:side fill-slot="side" tal:define="context_menu context/menu:context">