launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

The proposal to merge lp:~abentley/launchpad/safe-branch-upgrade into lp:launchpad has been updated.

Description changed to:

= Summary =
Fix bug #777958: branch upgrade jobs keep transaction open

== Proposed fix ==
Use a context manager to check for open transactions.

== Pre-implementation notes ==
Pre-and mid-implementation call with deryck.

== Implementation details ==
Implement TransactionFreeOperation context manager to use with operations that
must have no transaction active (i.e. long-running operations).

Provide a second contextmanager, TransactionFreeOperation.require, that ensures
TransactionFreeOperation is used at least once in its context.

Also, there were some drive-by lint fixes.  Mostly removing unused variables.

== Tests ==
bin/test -t test_helpers -t test_upgrades_branch

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/scripts/helpers.py
  lib/lp/code/model/tests/test_branchjob.py
  lib/lp/scripts/tests/test_helpers.py
  lib/lp/code/model/branchjob.py

For more details, see:
https://code.launchpad.net/~abentley/launchpad/safe-branch-upgrade/+merge/60634
-- 
https://code.launchpad.net/~abentley/launchpad/safe-branch-upgrade/+merge/60634
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/safe-branch-upgrade into lp:launchpad.