launchpad-reviewers team mailing list archive

[Martin Pool <martinpool@xxxxxxxxx>]

OK, it turns out this was a bit more interesting than I thought:

The problem mail is actually sent from the upload processor calling back to the sourcepackagerecipebuild, not by the build itself.  It is sent at the time the package is accepted, not synchronously with the source being uploaded, which makes sense.  I think previously it was sent earlier, and there was still some code hinting that it was.

 * handleStatus returns a deferred and the tests were ignoring it; it turns out that this doesn't make any difference to the test result (because the mail is not being sent at this point) but it's still worth fixing
 
 * _handleStatus_OK in the sprb subclass should be deleted, but for a different reason: it's totally dead code.  by the time the superclass call returns, the status can never be FULLYBUILT, as discussed above

 * to make an exception to the general policy of sending mail on accepted binaries, we should change .notify

It would be nice if the notifications all fed into some kind of tuplespace stream so users could set a preference to get them or not, or get them through means other than mail.  But not tonight.


I do get one test failure, which I'm hoping might be spurious:


Error in test test_date_finished_set (lp.code.model.tests.test_sourcepackagerecipebuild.TestHandleStatusForSPRBuild)
Traceback (most recent call last):
DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 0x99894d0 [23.2258160114s] called=0 cancelled=0 Client.failIfNotConnected(TimeoutError('',))>
<DelayedCall 0x9902638 [24.3933241367s] called=0 cancelled=0 Client.failIfNotConnected(TimeoutError('',))>
<DelayedCall 0x98d0518 [25.5298428535s] called=0 cancelled=0 Client.failIfNotConnected(TimeoutError('',))>
<DelayedCall 0xa756ab8 [59.9995620251s] called=0 cancelled=0 ThreadedResolver._cleanup('generic-string231767', <Deferred at 0xa756d40>)>
<DelayedCall 0xa756950 [59.9996020794s] called=0 cancelled=0 ThreadedResolver._cleanup('generic-string603418', <Deferred at 0xa7562d8>)>
<DelayedCall 0x91823b0 [59.9996299744s] called=0 cancelled=0 ThreadedResolver._cleanup('generic-string548899', <Deferred at 0x9182290>)>


-- 
https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/778437-sprb-spam into lp:launchpad.