launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

I've had to rework the implementation a bit. wgrant told me that for binary package builds, we don't want notifications going out for dependency errors, since these are retried. My guess is that this is how the regression mentioned in the bug report came to be.

So I've added a list of allowed statuses for which notifications are allowed to be sent. The callbacks are passed a notification_allowed flag and will only send out the email if this flag is true. The handleStatus delegation methos looks to see if the passed in status is in the list and sets the flag accordingly. So SRP package builds include the MANUALDEPWAIT status in the list while the binary package builds don't.
-- 
https://code.launchpad.net/~wallyworld/launchpad/recipe-build-missing-dep-email/+merge/61058
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/recipe-build-missing-dep-email into lp:launchpad.