launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/expose-bpph-indep into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #783355 in Launchpad itself: "WebAPI: add a way to determine that a package is arch independent"
  https://bugs.launchpad.net/launchpad/+bug/783355

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/expose-bpph-indep/+merge/61077

There's currently no way to tell through the API whether a BinaryPackagePublishingHistory is architecture-specific. This branch exposes BPR.architecturespecific as BPPH.architecture_specific.
-- 
https://code.launchpad.net/~wgrant/launchpad/expose-bpph-indep/+merge/61077
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/expose-bpph-indep into lp:launchpad.

=== modified file 'lib/lp/soyuz/interfaces/publishing.py'
--- lib/lp/soyuz/interfaces/publishing.py	2011-03-07 07:05:39 +0000
+++ lib/lp/soyuz/interfaces/publishing.py	2011-05-16 08:38:15 +0000
@@ -44,6 +44,7 @@
     Interface,
     )
 from zope.schema import (
+    Bool,
     Choice,
     Date,
     Datetime,
@@ -788,6 +789,10 @@
         TextLine(
             title=_("Binary Package Version"),
             required=False, readonly=True))
+    architecture_specific = exported(
+        Bool(
+            title=_("Architecture Specific"),
+            required=False, readonly=True))
     priority_name = exported(
         TextLine(
             title=_("Priority Name"),

=== modified file 'lib/lp/soyuz/model/publishing.py'
--- lib/lp/soyuz/model/publishing.py	2011-04-13 16:03:28 +0000
+++ lib/lp/soyuz/model/publishing.py	2011-05-16 08:38:15 +0000
@@ -953,6 +953,11 @@
         return self.binarypackagerelease.version
 
     @property
+    def architecture_specific(self):
+        """See `IBinaryPackagePublishingHistory`"""
+        return self.binarypackagerelease.architecturespecific
+
+    @property
     def priority_name(self):
         """See `IBinaryPackagePublishingHistory`"""
         return self.priority.name

=== modified file 'lib/lp/soyuz/stories/webservice/xx-binary-package-publishing.txt'
--- lib/lp/soyuz/stories/webservice/xx-binary-package-publishing.txt	2010-10-18 22:24:59 +0000
+++ lib/lp/soyuz/stories/webservice/xx-binary-package-publishing.txt	2011-05-16 08:38:15 +0000
@@ -65,6 +65,7 @@
 
     >>> from lazr.restful.testing.webservice import pprint_entry
     >>> pprint_entry(pubs['entries'][0])
+    architecture_specific: True
     archive_link: u'http://.../~cprov/+archive/ppa'
     binary_package_name: u'mozilla-firefox'
     binary_package_version: u'1.0'