launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/keyserver-port-fix-785155 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #785155 in Launchpad itself: "rocketfuel-setup should get the keys using HTTP protocol"
  https://bugs.launchpad.net/launchpad/+bug/785155

For more details, see:
https://code.launchpad.net/~deryck/launchpad/keyserver-port-fix-785155/+merge/61609

This branch applies the fix from bug 785155 that was mentioned in a comment.  This is a simple fix to get rocketfuel-setup working from behind a firewall when it fetchs the key.  I noticed the fix when doing bug triage this morning and applied it to a branch since it's so simple.
-- 
https://code.launchpad.net/~deryck/launchpad/keyserver-port-fix-785155/+merge/61609
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/keyserver-port-fix-785155 into lp:launchpad.

=== modified file 'utilities/rocketfuel-setup'
--- utilities/rocketfuel-setup	2011-04-05 23:36:31 +0000
+++ utilities/rocketfuel-setup	2011-05-19 16:31:35 +0000
@@ -129,7 +129,7 @@
    sudo apt-key list | grep -q $key
    if [ $? -ne 0 ]; then
      echo "Retrieving key $key."
-     gpg --keyserver keyserver.ubuntu.com --recv-keys $key
+     gpg --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys $key
      if [ $? -ne 0 ]; then
        echo "Could not retrieve key $key."
        exit 1