launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/db-bug-786822 into lp:launchpad/db-devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #786822 in Launchpad itself: "+localpackagediffs: Packages with pending syncs not displayed properly"
  https://bugs.launchpad.net/launchpad/+bug/786822

For more details, see:
https://code.launchpad.net/~jtv/launchpad/db-bug-786822/+merge/61924

= Summary =

As a provisional first stab at showing DistroSeriesDifferences on the DistroSeries:+localpackagediffs page that are waiting to be synchronized, I tried to replace the checkbox next to the DSD with an icon plus a "(Synchronizing)" text.  That actually went wrong because I accidentally hid not just the checkbox but the package name as well.

In this iteration I fixed that, and moved the marker text behid the package name.  Instead of an icon for DSDs for which a sync request does not make sense, I now just show a disabled checkbox.

Further tweaking of the display done with Huwshimi, our UI Guy.


== Tests ==

I didn't think it was worth a relatively heavyweight test just to ensure that the package name still appears.  But the browser tests still pass.


== Demo and Q/A ==

Go to https://dogfood.launchpad.net/ubuntu/oneiric/+localpackagediffs while logged in as a user privileged to synchronize packages (when in doubt, ask William).  Request more syncs than the soyuz.derivation.max_synchronous_syncs feature flag allows to be done synchronously, so that they will be done asynchronously instead.

Now, the syncs you requested now have their checkboxes disabled, plus a discreet "synchronizing…" text next to the package name.


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/distroseries-localdifferences.pt
-- 
https://code.launchpad.net/~jtv/launchpad/db-bug-786822/+merge/61924
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/db-bug-786822 into lp:launchpad/db-devel.

=== modified file 'lib/lp/registry/templates/distroseries-localdifferences.pt'
--- lib/lp/registry/templates/distroseries-localdifferences.pt	2011-05-20 09:28:55 +0000
+++ lib/lp/registry/templates/distroseries-localdifferences.pt	2011-05-23 07:31:33 +0000
@@ -77,21 +77,28 @@
                 tal:attributes="class src_name">
 
               <td>
-                <tal:checkbox tal:condition="python: view.canRequestSync(difference)">
-                  <input tal:condition="can_perform_sync"
+                <tal:checkbox
+                    condition="can_perform_sync"
+                    define="can_request python:view.canRequestSync(difference)">
+                  <input tal:condition="can_request"
                     name="field.selected_differences" type="checkbox"
                     tal:attributes="
                       value diff_id;
                       id string:field.selected_differences.${diff_id}"/>
-
-                  <a tal:attributes="href difference/fmt:url"
-                     class="js-action toggle-extra"
-                     tal:content="src_name">Foo</a>
+                  <input
+                    tal:condition="not: can_request"
+                    type="checkbox" disabled="disabled" />
                 </tal:checkbox>
-                <tal:clockface condition="python: view.hasPendingSync(difference)">
-                  <span class="sprite build_depwait"></span>
-                  <i>(Synchronizing)</i>
-                </tal:clockface>
+
+                <a tal:attributes="href difference/fmt:url"
+                   class="js-action toggle-extra"
+                   tal:content="src_name">Foo</a>
+
+                <span
+                    style="color:grey"
+                    tal:condition="python: view.hasPendingSync(difference)">
+                    &nbsp;&nbsp;synchronizing&hellip;
+                </span>
               </td>
               <td tal:condition="python: not(view.has_unique_parent) and view.show_parent_version">
                 <a tal:attributes="href difference/parent_series/fmt:url"