← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~julian-edwards/launchpad/packageupload-with-pcj into lp:launchpad/db-devel

 

- Renaming makePackageCopyJob() to makePlainPackageCopyJob() might
  avoid some confusion: PackageCopyJob is a model object, and
  PlainPackageCopyJob is one of possibly many wrappers around
  PackageCopyJob. Or, change makePackageCopyJob() to return
  PackageCopyJob and use the function mentioned below to get the
  runnable job (i.e. PlainPackageCopyJob).

- Here's a function - http://paste.ubuntu.com/613674/ - that will
  magically wrap any given job model instance with its corresponding
  runnable job class.

-- 
https://code.launchpad.net/~julian-edwards/launchpad/packageupload-with-pcj/+merge/62631
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/launchpad/packageupload-with-pcj into lp:launchpad/db-devel.


Follow ups