launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/silence-rf-get into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/silence-rf-get/+merge/62788

This branch removes two warnings from rocketfuel-get. I think they can be removed for the following reasons:

1. Due to Aaron's brilliant work, updating sourcedeps is now cached, which means in the usual case, it takes a very short amount of time to trundle over all of them.
2. Since Launchpad no longer has any private branches as optional sourcedeps since the demise of shipit, we don't need to warn either.
3. Removing six lines of output is a win in and of itself.
-- 
https://code.launchpad.net/~stevenk/launchpad/silence-rf-get/+merge/62788
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/silence-rf-get into lp:launchpad.

=== modified file 'utilities/rocketfuel-get'
--- utilities/rocketfuel-get	2010-10-24 21:00:11 +0000
+++ utilities/rocketfuel-get	2011-05-29 06:39:30 +0000
@@ -1,6 +1,6 @@
 #! /bin/bash
 #
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2011 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 #
 # Update your copy of trunk and the necessary source dependencies, and make
@@ -57,12 +57,6 @@
 
 echo "Updating sourcecode dependencies in rocketfuel:"
 echo ""
-echo "  NOTE: Each sourcedep may take a while; please be patient."
-echo ""
-echo "  ALSO NOTE: You can ignore any warnings you see below about how"
-echo "  'You have not informed bzr of your Launchpad ID ...' etc."
-echo "  See https://bugs.launchpad.net/bzr/+bug/401617 for why."
-echo ""
 echo "    Sourcedeps: $LP_SOURCEDEPS_PATH"
 
 run-child $LP_TRUNK_PATH/utilities/update-sourcecode $LP_SOURCEDEPS_PATH $sourcedeps_conf