launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~adeuring/launchpad/bug-486824 into lp:launchpad

To: mp+62883@xxxxxxxxxxxxxxxxxx
From: Abel Deuring <abel.deuring@xxxxxxxxxxxxx>
Date: Mon, 30 May 2011 16:04:24 -0000
In-reply-to: <20110530142814.13223.82397.codereview@gac.canonical.com>
Reply-to: mp+62883@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Francis,

thanks for the hints. I wasn't aware of urlfetch() and forgot completely
that we can record details in the timeline...

both done.

On 30.05.2011 16:33, Francis J. Lacoste wrote:
> We already have a urlfetch() wrapper that integrates urlopen with our timeout infrastructure. We used it for google integration.
> 
> See canonical.lazr.timeout and lib/canonical/launchpad/doc/timeout.txt for more information.
> 
> Another nice addition would be to add information to the request timeline so that we know what is happening.


-- 
https://code.launchpad.net/~adeuring/launchpad/bug-486824/+merge/62883
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~adeuring/launchpad/bug-486824 into lp:launchpad.