launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

The proposal to merge lp:~wallyworld/lazr-js/picker-entry-extra-title-links into lp:lazr-js has been updated.

Description changed to:

For the disclosure feature work, enhancements are required to the picker - extra information needs to be rendered so that the user can be confident that they are choosing the correct entry.

This branch provides the infrastructure to allow picker implementations to:
1. Render an alternate title for each picker entry - rendered in parentheses after the main title
2. Optionally provide hrefs for title/alt title which cause these to be rendered as anchors and the links are opened in new windows.
3. Optionally render badges (small images) to the right of the picker entry title.

Building the tarball to test this branch revealed a bug introduced to build.py. A change was made to allow the combo build to be invoked from the source directory rather than the egg. This broke Launchpad's jsbuild so a fix was done to cater for both scenarios. 

== Implementation ==

Modify the picker rendering javascript. The title and description rendering is broken out to separate functions. The description is not rendered any differently but may be for subsequent work.

There's one lint error - I'm not sure exactly what I need to change to fix it.

== Demo ==

See screenshot : http://people.canonical.com/~ianb/person-picker-links.png
This example shows just the alternate titles having links.

== Tests ==

Add new tests to picker/tests/picker.js

== Lint ==

jslint: 2 files to lint.
jslint: No problem found in '/home/ian/projects/lazrjs-branches/devel/src-js/lazrjs/picker/picker.js'.

jslint: Lint found in '/home/ian/projects/lazrjs-branches/devel/src-js/lazrjs/picker/tests/picker.js':
Line 158 character 52: Script URL.
            Assert.areEqual(link_node.get('href'), 'javascript:void(0)');

For more details, see:
https://code.launchpad.net/~wallyworld/lazr-js/picker-entry-extra-title-links/+merge/63069
-- 
https://code.launchpad.net/~wallyworld/lazr-js/picker-entry-extra-title-links/+merge/63069
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/lazr-js/picker-entry-extra-title-links into lp:lazr-js.