launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/ie-filebug-error-500015 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #500015 in Launchpad itself: "IE js error in filebug"
  https://bugs.launchpad.net/launchpad/+bug/500015

For more details, see:
https://code.launchpad.net/~deryck/launchpad/ie-filebug-error-500015/+merge/63763

This fixes the filebug page JavaScript to work in IE. Internet Explorer users rejoice, you can now file bugs on Launchpad!

The IE event facade wasn't being setup correctly. Rather than bloat launchpad.js for one interaction, I removed the YUI config params for bootstap and combine which gets things working for IE.  This suggests additional modules are being loaded for IE, but limited debug tools in IE make this hard to confirm for sure.  I don't see anything reported in the IE consoles I have, but I can't be sure.  I don't completely trust these tools.  There's certainly no effect in FF or Chromium.  This was only to help Windmill tests anyway, to prevent loading anything extra via Windmill's proxy.  Since we're not using Windmill anymore, there's no harm removing these config params.  I'll leave the fetchCSS and timeout params for paranoia and to prevent ugly warning logs in browser consoles.

I'll approve this myself, since it's a simple and harmless change.
-- 
https://code.launchpad.net/~deryck/launchpad/ie-filebug-error-500015/+merge/63763
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/ie-filebug-error-500015 into lp:launchpad.

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2011-05-24 08:22:39 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2011-06-07 20:48:38 +0000
@@ -79,12 +79,8 @@
   <script type="text/javascript">
     // Define a global YUI sandbox that should be used by everyone.
     var LPS = YUI({
-      // Don't try to fetch the loader module.
-      bootstrap: false,
       // Don't try to fetch CSS files.
       fetchCSS: false,
-      // Turn off combo loading.
-      combine: false,
       // For paranoia, set a low timeout to not wait on loading a resource.
       timeout: 50
       });