launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

The proposal to merge lp:~danilo/launchpad/bug-772754-other-subscribers-loading into lp:launchpad has been updated.

Description changed to:

= Bug 772754: Other subscribers list, part 5 =

Warning: oversized branch. Perhaps should have split it up into server-side and JS branches.

This is part of ongoing work for providing the "other subscribers" list as indicated in mockup https://launchpadlibrarian.net/71552495/all-in-one.png attached to bug 772754 by Gary.

This branch builds on top of the previous branches and provides finally ties in all the SubscribersList JS code with the actual subscribers loading.

To do the loading, method getDirectSubscribersWithDetails is added to provide both subscriber Person records and BugSubscription records in one go (for the sake of bug_notification_level, which is needed to determine which section a subscriber goes to).

For 'Maybe notified' subscribers, we are using existing APIs (getIndirectSubscribers).

Output of these methods is further hooked up into view +bug-portlet-subscriber-details which provides JSON suitable for direct use by the loading JS.

Note how this doesn't really remove any of the existing subscribers loading, so you end up with two subscribers lists after this.

It is comprehensively tested (I believe).  An integration test would be nice, but definitely for a later branch.

Considering the branch is over-sized already, I didn't bother looking into model/bug.py lint issues (except that I made sure I introduced no new ones).

== Tests ==

lp/bugs/javascript/tests/test_subscribers_list.html

bin/test -cvvt BugPortletSubscribersWithDetailsTests -t test_get_direct_subscribers_with_details

== Demo and Q/A ==

N/A

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/configure.zcml
  lib/lp/bugs/browser/bugsubscription.py
  lib/lp/bugs/browser/configure.zcml
  lib/lp/bugs/browser/tests/test_bugsubscription_views.py
  lib/lp/bugs/interfaces/bug.py
  lib/lp/bugs/javascript/subscribers_list.js
  lib/lp/bugs/javascript/tests/test_subscribers_list.js
  lib/lp/bugs/model/bug.py
  lib/lp/bugs/model/tests/test_bug.py
  lib/lp/bugs/templates/bug-portlet-subscribers.pt
  lib/lp/bugs/templates/bugtask-index.pt

./lib/lp/bugs/model/bug.py
      52: 'SQLRaw' imported but unused
      52: 'Join' imported but unused
      52: 'Exists' imported but unused
     171: 'get_bug_privacy_filter' imported but unused
      52: 'Count' imported but unused
     303: E301 expected 1 blank line, found 0
    2607: E225 missing whitespace around operator
make: *** [lint] Error 7

For more details, see:
https://code.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-loading/+merge/64186
-- 
https://code.launchpad.net/~danilo/launchpad/bug-772754-other-subscribers-loading/+merge/64186
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-772754-other-subscribers-loading into lp:launchpad.