launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/launchpad/bug-791204 into lp:launchpad has been updated.

Description changed to:

= Summary =

The soyuz queue script and +queue page are going to display PackageUploads with PackageCopyJobs.  This type of PackageUpload isn't currently displayed (at least not unless they also have other kinds of items attached) because DistroSeries.getQueueItems doesn't find them; we're replacing that method with DistroSeries.getPackageUploads which does.

First we must make sure that the script and the view can handle this type of job.  In this branch you'll see some of the groundwork for that.

== Proposed fix ==

Several attributes that a PackageUpload previously got from its source or build upload may now have to be gleaned from its PackageCopyJob instead.  This requires encapsulating them in PackageUpload, which knows where to get the information, rather than have the TAL or anyone just poking around its details.

== Pre-implementation notes ==

This does not actually replace getQueueItems calls with getPackageUploads calls yet.  That involves more work, such as supporting a few more filters that getQueueItems has and sorting out the ordering story.

== Implementation details ==

Working with Julian on this.  Separate branches will add functionality to bring getPackageUploads up to par with getQueueItems, and convert getQueueItems calls to use getPackageUploads instead.  We're also still working out how to sort.

== Tests ==

{{{
./bin/tests lp.soyuz.scripts.tests.test_queue
./bin/tests lp.soyuz.browser.tests.test_queue
./bin/tests lp.soyuz.tests.test_packageupload
}}}

== Demo and Q/A ==

The queue script will work as before, as will the +queue page.

= Launchpad lint =

There's some lint that I fixed in a separate branch, which should be about to go into PQM.  At that point the diff should become a bit smaller, because some of the fixes are duplicated.

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/soyuz/browser/tests/test_queue.py
  lib/lp/soyuz/model/queue.py
  lib/lp/soyuz/interfaces/queue.py
  lib/lp/soyuz/scripts/tests/test_queue.py
  lib/lp/soyuz/browser/queue.py
  lib/lp/soyuz/configure.zcml
  lib/lp/soyuz/tests/test_packageupload.py
  lib/lp/soyuz/scripts/queue.py

./lib/lp/soyuz/browser/queue.py
     328: local variable 'header' is assigned to but never used
     361: E203 whitespace before ':'
     501: W391 blank line at end of file

For more details, see:
https://code.launchpad.net/~jtv/launchpad/bug-791204/+merge/64390
-- 
https://code.launchpad.net/~jtv/launchpad/bug-791204/+merge/64390
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/bug-791204 into lp:launchpad.