launchpad-reviewers team mailing list archive

[Raphaël Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/launchpad/init-series-bug-789091-initseries into lp:launchpad has been updated.

Description changed to:

This branch fixes the UI to support the second use-case for initializing series (+initseries).
- Use case #1 (is_first_derivation=True): if the distribution has no initialized series, the series to be initialized can be initialized from one or more parents and the +initseries page allows to choose the architectures and the packagesets to be copied from the parents
- Use case #2 (is_first_derivation=False): if the distribution already has an initialized series, the series parent should be by default populated with the previous_series's parents (but this can be changed, DistroSeriesDerivationVocabulary is the vocabulary of allowed parents), no packageset picker should be displayed (all the packagesets will be copied) and the possible architecture should be the ones from the previous_series.

Note: The Javascript file (lib/lp/registry/javascript/distroseries.js) has been rewritten a bit to ease the testing (basically I've split the widget creating and the wiring of the widgets together to be able to monkeypatch the interaction with the LP server).

= Tests =

./bin/test -cvv test_distroseries test_is_first_derivation
./bin/test -cvv test_distroseries test_not_is_first_derivation

lib/lp/registry/javascript/tests/test_distroseries.html

= Q/A =

Test the +initseries form for the 2 use cases.

In the second use case (an initialized series already exists), make sure that:
- the parent picker is pre-populated with the previous_series' parents
- the architecture list is from the previous_series
- the packageset picker is not displayed
- the derivation was made from the previous series
- the parents (DSP) are the parents from the parent picker

For more details, see:
https://code.launchpad.net/~rvb/launchpad/init-series-bug-789091-initseries/+merge/64567
-- 
https://code.launchpad.net/~rvb/launchpad/init-series-bug-789091-initseries/+merge/64567
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/init-series-bug-789091-initseries into lp:launchpad.