launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

The proposal to merge lp:~lifeless/launchpad/bug-793848 into lp:launchpad/db-devel has been updated.

Description changed to:

This branch gets the table scan component of the bug stats portlet using bugsummary.

It needs the new columns only available in db-devel; along the way I saw dead code that confused me, so I deleted it.

I've added a interface for things that are dimensions in the bugsummary, this lets me avoid code duplication between the tags counting code and countBugs. In fact, in a future branch we probably want to delete the special cased tag counting code.

Oh, and I removed code duplication in the tags counting code, making the only variation the joining condition logic. The previous duplicate code I pulled up to an appropriate common base class.

For more details, see:
https://code.launchpad.net/~lifeless/launchpad/bug-793848/+merge/65158
-- 
https://code.launchpad.net/~lifeless/launchpad/bug-793848/+merge/65158
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/launchpad/bug-793848 into lp:launchpad/db-devel.