launchpad-reviewers team mailing list archive

[Jonathan Riddell <jriddell@xxxxxxxxxx>]

Jonathan Riddell has proposed merging lp:~jr/launchpad/421664-code-tab-hover-text into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #421664 in Launchpad itself: "Bad hover text for "Code" tab on package branch listings"
  https://bugs.launchpad.net/launchpad/+bug/421664

For more details, see:
https://code.launchpad.net/~jr/launchpad/421664-code-tab-hover-text/+merge/66346

add hover text for distro package pages
-- 
https://code.launchpad.net/~jr/launchpad/421664-code-tab-hover-text/+merge/66346
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jr/launchpad/421664-code-tab-hover-text into lp:launchpad.

=== modified file 'lib/lp/registry/browser/distributionsourcepackage.py'
--- lib/lp/registry/browser/distributionsourcepackage.py	2011-06-23 13:03:40 +0000
+++ lib/lp/registry/browser/distributionsourcepackage.py	2011-06-29 16:28:33 +0000
@@ -128,6 +128,21 @@
     usedfor = IDistributionSourcePackage
     enable_only = ['overview', 'bugs', 'answers', 'branches']
 
+    def overview(self):
+        text = 'Overview'
+        summary = 'General information about {0}'.format(self.context.displayname)
+        return Link('', text, summary)
+
+    def bugs(self):
+        text = 'Bugs'
+        summary = 'Bugs reported about {0}'.format(self.context.displayname)
+        return Link('', text, summary)
+
+    def branches(self):
+        text = 'Code'
+        summary = 'Branches for {0}'.format(self.context.displayname)
+        return Link('', text, summary)
+
 
 class DistributionSourcePackageLinksMixin:
 

=== modified file 'lib/lp/registry/browser/sourcepackage.py'
--- lib/lp/registry/browser/sourcepackage.py	2011-05-27 21:12:25 +0000
+++ lib/lp/registry/browser/sourcepackage.py	2011-06-29 16:28:33 +0000
@@ -210,6 +210,26 @@
     usedfor = ISourcePackage
     enable_only = ['overview', 'bugs', 'branches', 'translations']
 
+    def overview(self):
+        text = 'Overview'
+        summary = 'General information about {0}'.format(self.context.displayname)
+        return Link('', text, summary)
+
+    def bugs(self):
+        text = 'Bugs'
+        summary = 'Bugs reported about {0}'.format(self.context.displayname)
+        return Link('', text, summary)
+
+    def branches(self):
+        text = 'Code'
+        summary = 'Branches for {0}'.format(self.context.displayname)
+        return Link('', text, summary)
+
+    def translations(self):
+        text = 'Translations'
+        summary = 'Translations of {0} in Launchpad'.format(self.context.displayname)
+        return Link('', text, summary)
+
 
 class SourcePackageOverviewMenu(ApplicationMenu):