launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

The proposal to merge lp:~wallyworld/launchpad/lazrjs-picker-consolidate into lp:launchpad has been updated.

Description changed to:

Now that the lazr-js Javascript is in the lp tree, cleanup needs to be done. This branch consolidates the picker implementations.

== Implementation ==

Take the lp picker extensions for rendering additional details (as required for disclosure) and merge into the lazr picker code.
Move the lp person picker implementation into the new lp lazr tree.
Place the pickers into the Y.lazr.picker namespace (was previously Y.lazr and lp.app.picker)

There were a number of tests related to the "Assign Me"/"Remove" links which were in the picker test suite. These were moved to the person picker test suite since the person picker provides the code to implement these links.

So the current picker related code is:

lp/app/javascript/lazr/picker.js
 - the core picker implementation

lp/app/javascript/lazr/person_picker.js
 - extends picker to provide support for "assign to me", and "remove me" buttons

lp/app/javascript/picker_patcher.js (renamed from picker.js to avoid confusion as to what it provides)
 - adds support for using a picker to patch a resource attribute
 - provides a create() method to instantiate a picker
 - add yes/no conformation

There is still more to be done. The yesno confirmation code should be split out, the tests need to be consolidated etc. The person picker test cases should inherit from the base picker ones (there's a fair bit of code duplication that would be removed).

The lazr tests for the picker have not yet been combined with the lp ones - there's additional work required to integrate all lazr tests and so this will be done separately.

== Tests ==

bin/test -vvc -layer=YUI

== Lint ==

Sadly jslint didn't complete - it was consuming > 2.2Gb of RAM and 100% CPU when it was killed.

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/lazrjs-picker-consolidate/+merge/66847
-- 
https://code.launchpad.net/~wallyworld/launchpad/lazrjs-picker-consolidate/+merge/66847
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/lazrjs-picker-consolidate into lp:launchpad.