launchpad-reviewers team mailing list archive

["j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>]

=== modified file 'lib/lp/app/widgets/popup.py'
--- lib/lp/app/widgets/popup.py	2011-06-28 16:55:25 +0000
+++ lib/lp/app/widgets/popup.py	2011-07-05 18:16:23 +0000
@@ -31,8 +31,8 @@
     # Provide default values for the following properties in case someone
     # creates a vocab picker for a person instead if using the derived
     # PersonPicker.
-    show_assign_me_button = False
-    show_remove_button = False
+    show_assign_me_button = 'false'
+    show_remove_button = 'false'
 
     popup_name = 'popup-vocabulary-picker'
 
@@ -164,8 +164,8 @@
 class PersonPickerWidget(VocabularyPickerWidget):
 
     include_create_team_link = False
-    show_assign_me_button = True
-    show_remove_button = True
+    show_assign_me_button = 'true'
+    show_remove_button = 'true'
 
     @property
     def picker_type(self):

=== modified file 'lib/lp/registry/browser/team.py'
--- lib/lp/registry/browser/team.py	2011-06-28 11:26:36 +0000
+++ lib/lp/registry/browser/team.py	2011-07-05 18:16:23 +0000
@@ -984,8 +984,7 @@
             failed_names = [person.displayname for person in failed_joins]
             failed_list = ", ".join(failed_names)
 
-            mapping=dict(
-                this_team=target_team.displayname,
+            mapping = dict( this_team=target_team.displayname,
                 failed_list=failed_list)
 
             if len(failed_joins) == 1:
@@ -1035,9 +1034,13 @@
 
     schema = ITeamMember
     label = "Select the new member"
+    # XXX: jcsackett 5.7.2011 The assignment of 'false' to the vars below
+    # should be changed to the more appropriate False bool when we're making
+    # use of the JSON cache to setup pickers, rather than assembling
+    # javascript in a a view hacro.
     custom_widget(
         'newmember', PersonPickerWidget,
-        show_assign_me_button=False, show_remove_button=False)
+        show_assign_me_button='false', show_remove_button='false')
 
     @property
     def page_title(self):

-- 
https://code.launchpad.net/~jcsackett/launchpad/button-configs-break-pickers/+merge/67047
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/button-configs-break-pickers into lp:launchpad.