launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

The proposal to merge lp:~danilo/launchpad/expander-anim into lp:launchpad has been updated.

Description changed to:

= Expander animations =

This branch provides nice, reversible expander animations.  With lazr-js moved inside the tree, I add a few notes about the problems I've seen with existing slide-out, slide-in animations, and instead provide a new reversible slide out animation that is smart about pausing and restarting where appropriate.

Since I am actually refactoring the expanders, I've decided to not fix slide-out/slide-in because that would expand the already big scope.  Ideally, they would be replaced with the reversible_slide_out animation altogether.  Tests are also missing for it: hopefully not a big deal (I do want to provide them for the reversible stuff).

To actually play with it, try lp:~danilo/launchpad/replace-expanders-1 and then visit https://launchpad.dev/~mark/+archive/ppa and try clicking 'Technical details' (very quickly) or any bug page and use the arrow toggler for bug task details.

== Tests ==

lib/lp/app/javascript/tests/test_expander.html

== Demo and Q/A ==

We can only demo and/or QA this when the follow-up branch lands.  Not used anywhere yet.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/javascript/expander.js
  lib/lp/app/javascript/lazr/effects/effects.js
  lib/lp/app/javascript/tests/test_expander.js

For more details, see:
https://code.launchpad.net/~danilo/launchpad/expander-anim/+merge/67161
-- 
https://code.launchpad.net/~danilo/launchpad/expander-anim/+merge/67161
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/expander-anim into lp:launchpad.