launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/launchpad/bug-806946 into lp:launchpad has been updated.

Description changed to:

= Summary =

There's a package-name search box on +localpackagediffs.  When the name matches that of a packageset for the context distroseries, we want the page to show packages from that packageset.

== Proposed fix ==

This is a model change only.  The UI and the web-service API may also need updating once we know that this performs well enough.

== Pre-implementation notes ==

It was wisely decided to honour only exact matches on packageset names.  Ordering of results should not be affected.

== Implementation details ==

I did not widen the main search join, because it may affect ordering and uniqueness to a painful extent.  Instead there's a one-off sub-query that I hope the query optimizer will execute separately, and quickly.

There was a weird failure on the JavaScript test test_distroseries.js, when run from the command line with -t test_distroseries.  It does pass when run from the browser, or with -t javascript as a test selector.  Ian's currently landing JS test cleanup may fix that; I am inclined to believe that it's not related to my changes here.  An EC2 test is underway to verify this.

== Tests ==

{{{
./bin/test -vvc lp.registry.tests.test_distroseriesdifference
}}}

== Demo and Q/A ==

Go to https://dogfood.launchpad.net/ubuntu/oneiric/+localpackagediffs and try entering a packageset name, such as "core" into the package name filter.

Pay particular attention to performance.  There probably won't be any noticeable effect if the name you enter is not a packageset name, but when it is, performance needs watching.

= Launchpad lint =

There's one bit of pre-existing lint where somebody else's branch had a problem.  Rather than touching it myself, I notified the author and it's being fixed.

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/tests/test_distroseriesdifference.py
  lib/lp/soyuz/model/packagecopyjob.py
  lib/lp/registry/interfaces/distroseriesdifference.py
  lib/lp/soyuz/interfaces/packageset.py
  lib/lp/registry/model/distroseriesdifference.py
  lib/lp/registry/model/distroseries.py
  lib/lp/registry/browser/distroseries.py

./lib/lp/soyuz/model/packagecopyjob.py
     487: W291 trailing whitespace

For more details, see:
https://code.launchpad.net/~jtv/launchpad/bug-806946/+merge/67302
-- 
https://code.launchpad.net/~jtv/launchpad/bug-806946/+merge/67302
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/bug-806946 into lp:launchpad.