launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

The proposal to merge lp:~danilo/launchpad/remove-mochi-stuff into lp:launchpad has been updated.

Description changed to:

= Summary =

Remove unused code.  activateCollapsibles was replaced long time ago with YUI-based implementation activate_collapsibles.  Remove any trace of it from the source code.

One step closer to getting rid of the mochikit stuff.

There's a million CSS lint warnings (I've snipped them out to reduce the MP size), and a few JS ones, but I am not touching them because this JS needs to die.

== Tests ==

Test suite.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/app/javascript/lp-mochi.js
  lib/lp/app/templates/base-layout.pt

./lib/canonical/launchpad/icing/style-3-0.css
      58: Unknown Property name.: -moz-border-radius
      59: Unknown Property name.: -webkit-border-radius
      60: Unknown Property name.: -khtml-border-radius
[snip]
      38: I003: To few newlines before selectors.
      41: I003: To few newlines before selectors.
      46: I003: To few newlines before selectors.
[snip]
./lib/lp/app/javascript/lp-mochi.js
      21: Expected '!==' and instead saw '!='.
      22: Unexpected 'continue'.
      24: Expected '===' and instead saw '=='.
      25: Unexpected 'continue'.
      27: Expected '===' and instead saw '=='.
      42: Move 'var' declarations to the top of the function.
      42: Stopping.  (18% scanned).
      -1: JSLINT had a fatal error.
make: *** [lint] Error 243

For more details, see:
https://code.launchpad.net/~danilo/launchpad/remove-mochi-stuff/+merge/67326
-- 
https://code.launchpad.net/~danilo/launchpad/remove-mochi-stuff/+merge/67326
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/remove-mochi-stuff into lp:launchpad.