← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~xaav/loggerhead/export-tarball into lp:loggerhead

 

>
>> [fix] It looks like you want tarballs disabled by default (which I agree with), so it seems a bit strange to me that the keyword arguments default to true.
>
> What line are you referring to?
>
@@ -49,7 +49,7 @@

     def __init__(self, branch, friendly_name=None, config={},
                  graph_cache=None, branch_link=None, is_root=False,
-                 served_url=_DEFAULT, use_cdn=False):
+                 served_url=_DEFAULT, use_cdn=False, export_tarballs=True):
         self.branch = branch
         self._config = config
         self.friendly_name = friendly_name

Fixed.
-- 
https://code.launchpad.net/~xaav/loggerhead/export-tarball/+merge/66408
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~xaav/loggerhead/export-tarball into lp:loggerhead.


References