← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~bryce/launchpad/component-url-formatter into lp:launchpad

 

Bryce Harrington has proposed merging lp:~bryce/launchpad/component-url-formatter into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~bryce/launchpad/component-url-formatter/+merge/67783

Refactor component editing with URL formatter

Suggested in code review of another branch by Jeroen and Gavin.
-- 
https://code.launchpad.net/~bryce/launchpad/component-url-formatter/+merge/67783
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~bryce/launchpad/component-url-formatter into lp:launchpad.
=== modified file 'lib/lp/bugs/templates/bugtracker-portlet-components.pt'
--- lib/lp/bugs/templates/bugtracker-portlet-components.pt	2011-06-03 05:47:32 +0000
+++ lib/lp/bugs/templates/bugtracker-portlet-components.pt	2011-07-13 02:54:28 +0000
@@ -28,7 +28,7 @@
                 tal:condition="component/distro_source_package"
                 tal:replace="structure component/distro_source_package/fmt:link" />
               <a class="menu-link-edit sprite edit"
-                tal:attributes="href string:${context/fmt:url}/+components/${component_group/id}/${component/id}/+edit"><span
+                tal:attributes="href context/component_group/fmt:url/+edit"><span
                   class="invisible-link">Edit component</span></a>
             </li>
           </ul>


Follow ups