launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/fix-806925 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #806925 in Launchpad itself: "Replace bug task, ppa details and package details expanders"
  https://bugs.launchpad.net/launchpad/+bug/806925

For more details, see:
https://code.launchpad.net/~danilo/launchpad/fix-806925/+merge/68070

= Bug 806925 QA fix =

William found a problem with DistroSourcePackage:+index page expanders.  Basically, I haven't realized that the same JS is used for two different templates (one was for PPA +packages page, which I QAd), so I haven't migrated the template for DSP:+index page.

Migration is simple.

== Demo and Q/A ==

https://launchpad.dev/ubuntu/+source/mozilla-firefox
-- 
https://code.launchpad.net/~danilo/launchpad/fix-806925/+merge/68070
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/fix-806925 into lp:launchpad.

=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt	2011-06-16 13:50:58 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt	2011-07-15 10:44:26 +0000
@@ -151,9 +151,7 @@
           <a class="expander"
              tal:attributes="id string:pub${pubid}-expander;
                              href string:${archive/fmt:url}/+sourcepub/${pubid}/+listing-archive-extra">
-            <img style="padding-right:0.5em;" src="/@@/treeCollapsed"
-                 alt="Show details" title="Show details"
-                 tal:attributes="id string:pub${pubid}-arrow"/>
+            &nbsp;
           </a>
           <a tal:attributes="href row/version">
             <img src="/@@/package-source" />
@@ -174,7 +172,7 @@
                content="string:(not published)"/>
         </td>
       </tr>
-      <tr tal:attributes="id string:pub${pubid}" style="display: none">
+      <tr tal:attributes="id string:pub${pubid}">
         <td colspan="3">
           <div class="package-details"
                tal:attributes="id string:pub${pubid}-container"></div>