launchpad-reviewers team mailing list archive

[Raphaël Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/launchpad/dsd-init-bug-808681 into lp:launchpad has been updated.

Description changed to:

This branch adds the creation of the DSDs as a part of the initialization process. DSD are created using the methods in lib/lp/registry/scripts/populate_distroseriesdiff.py if the parents have changed (compared to the previous_series' parent) or if only specific packagesets have been selected for the initialization. If not, then a simple copy from previous_series' DSDs is done. (This should speed up the initialization of Ubuntu series.)

= Details =

- New authorizations have been added to database/schema/security.cfg to allow scripts to manipulate the distroseriesdifference table.
- lib/lp/registry/scripts/populate_distroseriesdiff.py has been reworked a bit to be able to call its methods from outside the script.

= Tests =

./bin/test -vvc test_initialize_distroseries test__has_same_parents_as_previous_series_explicit
./bin/test -vvc test_initialize_distroseries test__has_same_parents_as_previous_series_implicit
./bin/test -vvc test_initialize_distroseries test_not__has_same_parents_as_previous_series
./bin/test -vvc test_initialize_distroseries test_initialization_copy_dsds
./bin/test -vvc test_initialize_distroseries test_initialization_compute_dsds
./bin/test -vvc test_initialize_distroseries test_initialization_compute_dsds_specific_packagesets

= QA =

On DF, make a post-first initialization of a series from multiple parents without changing the (pre-selected on the +initseries page) parents. Make sure that lp.net/distro/series/+localpackagediffs is populated and is the same as lp.net/distro/previous_series/+localpackagediffs.

On DF, make a post-first initialization of a series from multiple parents and add a new parent (compared to previous_series' parents). Make sure that lp.net/distro/series/+localpackagediffs is populated with diffs from the series and all of its parents.

For more details, see:
https://code.launchpad.net/~rvb/launchpad/dsd-init-bug-808681/+merge/68375
-- 
https://code.launchpad.net/~rvb/launchpad/dsd-init-bug-808681/+merge/68375
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/dsd-init-bug-808681 into lp:launchpad.