launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/germinate-ubuntustudio into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #562706 in Launchpad itself: "On i386, selecting the ubuntu studio packages fails to install"
  https://bugs.launchpad.net/launchpad/+bug/562706

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/germinate-ubuntustudio/+merge/68404

Summary: Ubuntu Studio has been an official Ubuntu flavour for ages.  We never got round to adding it to cron.germinate because it wasn't strictly required since we don't build live CDs of it; but bug 562706 documents a case where its absence from cron.germinate breaks things, so we should add it now.

Proposed fix: There are just a couple of lists that need extending.

QA: If necessary: run cron.germinate for oneiric on a staging Soyuz setup, and observe that the resulting more-extra.override.oneiric.main includes lines containing 'ubuntustudio-'.
-- 
https://code.launchpad.net/~cjwatson/launchpad/germinate-ubuntustudio/+merge/68404
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/germinate-ubuntustudio into lp:launchpad.

=== modified file 'cronscripts/publishing/cron.germinate'
--- cronscripts/publishing/cron.germinate	2011-07-13 12:19:45 +0000
+++ cronscripts/publishing/cron.germinate	2011-07-19 15:18:36 +0000
@@ -34,7 +34,7 @@
 cd $GERMINATEROOT
 
 # Clean up temporary files
-rm -f germinate.output ALL ALL.sources UBUNTU-* KUBUNTU-* EDUBUNTU-* XUBUNTU-* MYTHBUNTU-* LUBUNTU-*
+rm -f germinate.output ALL ALL.sources UBUNTU-* KUBUNTU-* EDUBUNTU-* XUBUNTU-* MYTHBUNTU-* LUBUNTU-* UBUNTUSTUDIO-*
 rm -f all_* all.sources_*
 rm -rf dists
 
@@ -56,7 +56,7 @@
 > "$MISCROOT/more-extra.override.$suite.main.new"
 
 germinate_components=main,universe,restricted,multiverse
-for distro in ubuntu kubuntu kubuntu-mobile edubuntu xubuntu mythbuntu lubuntu; do
+for distro in ubuntu kubuntu kubuntu-mobile edubuntu xubuntu mythbuntu lubuntu ubuntustudio; do
   DISTRO="$(echo $distro | tr a-z A-Z)"
   germinate_suite="$distro.$suite"
   for arch in i386 amd64 powerpc armel; do