launchpad-reviewers team mailing list archive

[Martin Pool <martinpool@xxxxxxxxx>]

merge approve
vote approve

I wonder if the automatic upgrades will be safe. Perhaps you should check
with Tim or guard it with a flag, if they're available there.
On Jul 21, 2011 3:30 AM, "Jelmer Vernooij" <jelmer@xxxxxxxxx> wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/launchpad/upgrade-stderr
into lp:launchpad.
>
> Requested reviews:
> Launchpad code reviewers (launchpad-reviewers)
> Related bugs:
> Bug #808035 in Launchpad itself: "AttributeError: 'NoneType' object has no
attribute 'write' during git import"
> https://bugs.launchpad.net/launchpad/+bug/808035
>
> For more details, see:
> https://code.launchpad.net/~jelmer/launchpad/upgrade-stderr/+merge/68579
>
> Fix processing of code imports that are in an old bzr format:
>
> 1) Implement show_user_warning in the custom LoggingUIFactory used in the
code import
> workers. This fixes the immediate issue that causes the traceback,
> and will prevent issues in the future if parts of bazaar print user
warnings.
>
> 2) Reintroduce the automatic upgrading of code imports, and fix the
related test.
> Previously the test would compare the formats of the bzr dirs, both of
which
> would be "Bazaar-NG meta directory, format 1". The test now compares the
> repository formats, which are different.
> --
> https://code.launchpad.net/~jelmer/launchpad/upgrade-stderr/+merge/68579
> You are subscribed to branch lp:launchpad.

-- 
https://code.launchpad.net/~jelmer/launchpad/upgrade-stderr/+merge/68579
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/upgrade-stderr into lp:launchpad.