launchpad-reviewers team mailing list archive

[Raphaël Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/launchpad/use-copier-first-init-bug-814643 into lp:launchpad has been updated.

Description changed to:

This branch makes it so that we use the package copier for first-initializing a series (https://dev.launchpad.net/LEP/DerivativeDistributions#Vocabulary). This is required because only the package copier (as opposed to the package cloner) copies packages other that only those in the RELEASE pocket and because the plan is to get rid of the cloner eventually.

I had to copy supports_virtualized from the parents when creating the child's architecture which is: a) the right thing to do. b) required by the fact that the copier is more precise about what it's doing and checks for supported architectures before creating binary packages).

As a drive-by cleanup, I also made _use_cloner a normal instance method.

= Tests =

./bin/test -vvc test_initialize_distroseries test_copy_method_first_derivation

= QA =

This should be marked as qa-untestable for now and properly tested as part of the fix for https://bugs.launchpad.net/launchpad/+bug/815751 (it will fix the call to the copier to call it with 3 pockets: RELEASED, UPDATES, SECURITY).

For more details, see:
https://code.launchpad.net/~rvb/launchpad/use-copier-first-init-bug-814643/+merge/69052
-- 
https://code.launchpad.net/~rvb/launchpad/use-copier-first-init-bug-814643/+merge/69052
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/use-copier-first-init-bug-814643 into lp:launchpad.