launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~deryck/launchpad/bug-heat-wonky-db-patch-688364 into lp:launchpad/db-devel

To: Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>
From: Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>
Date: Tue, 26 Jul 2011 09:06:11 -0000
In-reply-to: <20110722183732.21622.96394.launchpad@loganberry.canonical.com>
Reply-to: mp+68894@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve db
The db changes are fine.

I wonder if what you are doing is correct though? What happens with bugs targetted to a distribution but not a sourcepackagename? Would GREATEST(Product.max_bug_heat, LEAST(DistributionSourcePackage.max_bug_heat, Distribution.max_bug_heat)) be better?
-- 
https://code.launchpad.net/~deryck/launchpad/bug-heat-wonky-db-patch-688364/+merge/68894
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/bug-heat-wonky-db-patch-688364 into lp:launchpad/db-devel.

References

[Merge] lp:~deryck/launchpad/bug-heat-wonky-db-patch-688364 into lp:launchpad/db-devel
From: Deryck Hodge, 2011-07-22