← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~julian-edwards/launchpad/lease-time-bug-816326 into lp:launchpad

 

The proposal to merge lp:~julian-edwards/launchpad/lease-time-bug-816326 into lp:launchpad has been updated.

Description changed to:

= Summary =
Make job resumption clear the lease_expires so that it can be picked up by a runner right away.

== Implementation details ==
A very trivial change!  But submitted for review to double check that it will
DTRT in all circumstances.

The problem is that when a job suspends and then resumes later in quick succession, no runner picks it up because the lease_expires time has not passed.  This change just clears that lease time when resuming.

== Tests ==
bin/test -cvv test_job

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/job/tests/test_job.py
  lib/lp/services/job/model/job.py

For more details, see:
https://code.launchpad.net/~julian-edwards/launchpad/lease-time-bug-816326/+merge/69266
-- 
https://code.launchpad.net/~julian-edwards/launchpad/lease-time-bug-816326/+merge/69266
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/launchpad/lease-time-bug-816326 into lp:launchpad.


References