launchpad-reviewers team mailing list archive

[Henning Eggers <henning.eggers@xxxxxxxxxxxxx>]

Henning Eggers has proposed merging lp:~henninge/launchpad/bug-481512-reopen-logs into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #481512 in Launchpad itself: "race condition when rotating logs"
  https://bugs.launchpad.net/launchpad/+bug/481512

For more details, see:
https://code.launchpad.net/~henninge/launchpad/bug-481512-reopen-logs/+merge/69643

= Summary =

Use a development version of ZConfig that does locking when reopening
log files. Once this has proven to fix the problem for us, it will be
submitted upstream and the Version can be updated again.

== Pre-implementation notes ==

Talked this through with Gary, William and also Robert.

== Demo and Q/A ==

That is the big question. I don't see how this can be QA'ed other than
watching how production behaves with it. Other ideas?

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  versions.cfg

./versions.cfg
     246: Line exceeds 78 characters.
-- 
https://code.launchpad.net/~henninge/launchpad/bug-481512-reopen-logs/+merge/69643
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~henninge/launchpad/bug-481512-reopen-logs into lp:launchpad.

=== modified file 'versions.cfg'
--- versions.cfg	2011-07-27 05:48:20 +0000
+++ versions.cfg	2011-07-28 12:59:21 +0000
@@ -130,7 +130,7 @@
 zc.lockfile = 1.0.0
 zc.recipe.egg = 1.3.2
 zc.zservertracelog = 1.1.5
-ZConfig = 2.7.1
+ZConfig = 2.9.1dev-20110728
 zdaemon = 2.0.4
 ZODB3 = 3.9.2
 zodbcode = 3.4.0