← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~mbp/launchpad/mail-scope into lp:launchpad

 

Martin Pool has proposed merging lp:~mbp/launchpad/mail-scope into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #810290 in Launchpad itself: "no way to set scopes for incoming mail"
  https://bugs.launchpad.net/launchpad/+bug/810290

For more details, see:
https://code.launchpad.net/~mbp/launchpad/mail-scope/+merge/70095

Escape characters in the mail_header feature scope doc string need to be escaped or they mess up the +feature-info display.
-- 
https://code.launchpad.net/~mbp/launchpad/mail-scope/+merge/70095
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/mail-scope into lp:launchpad.
=== modified file 'lib/lp/services/features/scopes.py'
--- lib/lp/services/features/scopes.py	2011-05-27 23:24:02 +0000
+++ lib/lp/services/features/scopes.py	2011-08-02 00:48:38 +0000
@@ -184,7 +184,7 @@
     start.
 
     Headers are not unfolded before matching, so wrapped lines may appear as
-    "\n\t".
+    "\\n\\t" or similar.
     """
 
     pattern = r'mail_header:(?P<header_name>[^:]*):(?P<value_regex>.*)'


Follow ups