launchpad-reviewers team mailing list archive

[Raphael Victor Badin <raphael.badin@xxxxxxxxxxxxx>]

The proposal to merge lp:~rvb/launchpad/bug-820900 into lp:launchpad has been updated.

Description changed to:

This branch fixes an oops when the filtering key passed to +localpackagediffs is not a valid key). In this case we just add an error to the page and display no differences.

= Tests =

./bin/test -vvc test_distroserie test_batch_wrong_param

= QA =

This page should not oops anymore (note the field.package_type=RANDOM):
https://dogfood.launchpad.net/ubuntu/oneiric/+localpackagediffs?field.name_filter=&field.package_type=RANDOM&field.package_type-empty-marker=1

For more details, see:
https://code.launchpad.net/~rvb/launchpad/bug-820900/+merge/70434
-- 
https://code.launchpad.net/~rvb/launchpad/bug-820900/+merge/70434
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/bug-820900 into lp:launchpad.