launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

The proposal to merge lp:~wallyworld/launchpad/only-one-picker-expander-open-819580 into lp:launchpad has been updated.

Description changed to:

The branch wire up pickers to use the new expander group functionality.

== Implementation ==

Simply pass in a group_id config value when the picker expander is constructed.
A few drive by fixes were also made.

== Demo and QA ==

Open a bug task assignee picker, perform a search and click an expander to show details for an entry. Click another expander and the first opened one should close as the newly selected one opens.

== Tests ==

Write 2 new picker tests:
 test_expander_only_one_open
 test_expander_multiple_pickers

== Lint ==

Linting changed files:
  lib/lp/app/javascript/picker/picker.js
  lib/lp/app/javascript/picker/tests/test_picker.js

./lib/lp/app/javascript/picker/picker.js
      67: 'Picker' has not been fully defined yet.

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/only-one-picker-expander-open-819580/+merge/70393
-- 
https://code.launchpad.net/~wallyworld/launchpad/only-one-picker-expander-open-819580/+merge/70393
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/only-one-picker-expander-open-819580 into lp:launchpad.