launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

The proposal to merge lp:~danilo/launchpad/bug-811447 into lp:launchpad has been updated.

Description changed to:

= Bug #811447: pofile-stats.txt not found =

pofile-stats script runs very long (sometimes even 10 days) and during that time we get a few nodowntime deployments, thus replacing the LP tree with another one (with a different revision number in the tree path on our servers).

Thus, getting an email template fails when DBLoopTuner completes the run().

I will fix the lint issues after review and before landing.

== Proposed fix ==

Move the fetching of the email template before the loop is executed.

== Tests ==

bin/test -cvvt verify.stats

== Demo and Q/A ==

run the pofile-stats.py script and move the LP tree while it's running: it should still have the correct email template

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/translations/scripts/verify_pofile_stats.py

./lib/lp/translations/scripts/verify_pofile_stats.py
     121: E203 whitespace before ':'
     121: E225 missing whitespace around operator
     161: E203 whitespace before ':'
     198: E203 whitespace before ':'
     209: W391 blank line at end of file

For more details, see:
https://code.launchpad.net/~danilo/launchpad/bug-811447/+merge/70561
-- 
https://code.launchpad.net/~danilo/launchpad/bug-811447/+merge/70561
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-811447 into lp:launchpad.