launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/launchpad/packageset-picker-5 into lp:launchpad with lp:~allenap/launchpad/packageset-picker-4 as a prerequisite.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #814531 in Launchpad itself: "PackagesetPickerWidget does not consistently fire choicesChange events"
  https://bugs.launchpad.net/launchpad/+bug/814531

For more details, see:
https://code.launchpad.net/~allenap/launchpad/packageset-picker-5/+merge/71018

Make the list items that ChoiceListWidget renders have
white-space:nowrap, and also have overflow hidden with ellipsis on
text.
-- 
https://code.launchpad.net/~allenap/launchpad/packageset-picker-5/+merge/71018
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/packageset-picker-5 into lp:launchpad.

=== modified file 'lib/lp/app/javascript/formwidgets/formwidgets.js'
--- lib/lp/app/javascript/formwidgets/formwidgets.js	2011-08-10 10:27:52 +0000
+++ lib/lp/app/javascript/formwidgets/formwidgets.js	2011-08-10 10:27:53 +0000
@@ -335,7 +335,10 @@
                 "for", item.one("input").generateID())
             .setStyle("font-weight", "normal")
             .set("text", choice.text);
-        item.setData(choice.data);
+        item.setData(choice.data)
+            .setStyle("overflow", "hidden")
+            .setStyle("text-overflow", "ellipsis")
+            .setStyle("white-space", "nowrap");
         return item;
     },