launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

The proposal to merge lp:~lifeless/python-oops/extraction into lp:python-oops has been updated.

Description changed to:

More code from LP - the serialisation bits this time.

They are -clearly- clunky in a more flexible world, but I have not tried to improve them at all at this point (other than making an explicit test for to_chunks).

That can wait for an actual use case :).

The change to read() is so that an oops that is written, and then read, has as many fields as one in LP which is just directly created: this is really the fix for a long standing bug in LP where using its read() function would give you an oops claiming to be made by the current codebase, regardless of its origin.

For more details, see:
https://code.launchpad.net/~lifeless/python-oops/extraction/+merge/71128
-- 
https://code.launchpad.net/~lifeless/python-oops/extraction/+merge/71128
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/python-oops/extraction into lp:python-oops.