launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~stevenk/launchpad/denorm-bspph into lp:launchpad/db-devel

To: Steve Kowalik <stevenk@xxxxxxxxxx>
From: Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>
Date: Mon, 15 Aug 2011 06:43:24 -0000
In-reply-to: <20110812054328.11670.61306.launchpad@ackee.canonical.com>
Reply-to: mp+71303@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve db
We will also need to index this column. As we never delete or update bpn and spn rows, we can add these later as live database patches to avoid downtime as these are large tables. We will need indexes not only to support the desired searches, but also to allow the garbo job that will populate the new columns to complete this year.

You should open (at least) three bugs to track the todo stuff:
  - spph.sourcepackagename/bpph.binarypackagename not indexed
  - spph.sourcepackagename/bpph.binarypackagename not populated
  - spph.sourcepackagename/bpph.binarypackagename missing NOT NULL constraint
-- 
https://code.launchpad.net/~stevenk/launchpad/denorm-bspph/+merge/71303
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/denorm-bspph into lp:launchpad/db-devel.

References

[Merge] lp:~stevenk/launchpad/denorm-bspph into lp:launchpad/db-devel
From: Steve Kowalik, 2011-08-12