launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/launchpad/pre-824499 into lp:launchpad has been updated.

Description changed to:

= Summary =

I'm adding an option to publish-ftpmaster that makes it loop over all Ubuntu-derived distributions (instead of processing just one distribution as named on the command line).

This branch is a preparation for that work: instead of having the script use self.distribution everywhere, pass the distribution around explicitly.

== Implementation details ==

As you probably guessed, self.distribution becomes self.distributions in the follow-up branch.

Some tests used internals of the script to find publisher configs; I made those look up the configs in the "proper" way because the script internals are about the change.  Also fixed a bit of blatantly incorrect indentation, in a function I'm pretty sure I wrote no less.  But other than that, the only changes you should see here are distributions being passed as a parameter instead of as an attribute of the script.

== Tests ==

{{{
./bin/test -vvc lp.archivepublisher.tests.test_publish_ftparchive
}}}

== Demo and Q/A ==

No separate Q/A needed; that'll happen with the main branch.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/archivepublisher/scripts/publish_ftpmaster.py
  lib/lp/archivepublisher/tests/test_publish_ftpmaster.py

For more details, see:
https://code.launchpad.net/~jtv/launchpad/pre-824499/+merge/71536
-- 
https://code.launchpad.net/~jtv/launchpad/pre-824499/+merge/71536
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/pre-824499 into lp:launchpad.