launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~jelmer/launchpad/bzr-2.4b4 into lp:launchpad

To: mp+71624@xxxxxxxxxxxxxxxxxx
From: Graham Binns <graham@xxxxxxxxxxxxx>
Date: Tue, 16 Aug 2011 10:16:33 -0000
In-reply-to: <20110816002911.16515.74573.launchpad@ackee.canonical.com>
Reply-to: mp+71624@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code
Minor stylistic nitpick, otherwise this looks good:

236	+            Branch.hooks.uninstall_named_hook('transform_fallback_location',
237	+                'SafeBranchOpener.transformFallbackLocationHook')

Would be better written as:

            Branch.hooks.uninstall_named_hook(
                'transform_fallback_location',
                'SafeBranchOpener.transformFallbackLocationHook')
-- 
https://code.launchpad.net/~jelmer/launchpad/bzr-2.4b4/+merge/71624
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/bzr-2.4b4 into lp:launchpad.