launchpad-reviewers team mailing list archive

Thread
Date

[Merge] lp:~wgrant/launchpad/fix-codebrowse-oopses into lp:launchpad

To: mp+72515@xxxxxxxxxxxxxxxxxx
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Tue, 23 Aug 2011 01:40:30 -0000
Reply-to: mp+72515@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

William Grant has proposed merging lp:~wgrant/launchpad/fix-codebrowse-oopses into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/fix-codebrowse-oopses/+merge/72515

launchpad_loggerhead's OOPS page template uses %(oopsid)s, when oops_wsgi provides %(id)s. Let's fix that so the OOPS handler stops crashing.
-- 
https://code.launchpad.net/~wgrant/launchpad/fix-codebrowse-oopses/+merge/72515
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/fix-codebrowse-oopses into lp:launchpad.

=== modified file 'lib/launchpad_loggerhead/app.py'
--- lib/launchpad_loggerhead/app.py	2011-08-18 03:32:33 +0000
+++ lib/launchpad_loggerhead/app.py	2011-08-23 01:40:25 +0000
@@ -248,14 +248,14 @@
 #  - Andrew Bennetts, 2010-07-27.
 _oops_html_template = '''\
 <html>
-<head><title>Oops! %(oopsid)s</title></head>
+<head><title>Oops! %(id)s</title></head>
 <body>
 <h1>Oops!</h1>
 <p>Something broke while generating the page.
 Please try again in a few minutes, and if the problem persists file a bug at
 <a href="https://bugs.launchpad.net/launchpad";
 >https://bugs.launchpad.net/launchpad</a>
-and quote OOPS-ID <strong>%(oopsid)s</strong>
+and quote OOPS-ID <strong>%(id)s</strong>
 </p></body></html>'''